Linux: Enable build config wayland=yes use_sowrap=no
#92324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 24, 2024
akien-mga
changed the title
wayland=yes use_sowrap=no
jwinarske
force-pushed
the
jw/wayland_sowrap
branch
2 times, most recently
from
d69a9df
to
8ca144a
Compare
akien-mga
approved these changes
May 25, 2024
Riteo
requested changes
May 25, 2024
There was a problem hiding this comment.
Thanks for your contribution!
This include is indeed missing, but please note that the whole wrap/no-wrap include block is in platform/linux/wayland/wayland_thread.h:
godot/platform/linuxbsd/wayland/wayland_thread.h
Lines 38 to 47 in b7feebe
So, I think that it would be wiser (or at least more consistent) to put it there, in the else branch, between the xkbcommon and cursor include, so that we have two mirrored blocks.
(It took me a bit to find where the other includes came for so I understand that it's not very intuitive, sorry)
-wayland-egl.h was missing if opengl3=yes (default) Signed-off-by: Joel Winarske <joel.winarske@gmail.com>
jwinarske
force-pushed
the
jw/wayland_sowrap
branch
from
8ca144a
to
f06dd46
Compare
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables building with
wayland=yes use_sowrap=no.If
opengl3=nothen this change is not required.