Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate if/else code in TextEdit::_notification #92342

Merged
merged 1 commit into from
May 28, 2024

Conversation

aaronp64
Copy link
Contributor

@aaronp64 aaronp64 commented May 24, 2024

Production team notes: Does what it says on the tin.

@aaronp64 aaronp64 requested a review from a team as a code owner May 24, 2024 22:13
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@adamscott adamscott modified the milestones: 4.x, 4.3 May 24, 2024
@aaronp64 aaronp64 force-pushed the textedit_duplication branch from 801b428 to 05cc8e7 Compare May 25, 2024 14:50
@akien-mga akien-mga merged commit 194b1c4 into godotengine:master May 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@aaronp64 aaronp64 deleted the textedit_duplication branch June 28, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants