-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable camera_effects
when debug draw is active
#92524
Disable camera_effects
when debug draw is active
#92524
Conversation
camera_effects
when debug draw is active
4e9da84
to
49c769b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with Forward+ and Mobile (rebased on top of master
292e50e), it works as expected. Since this is done at a server level, this works both in the scenario where CameraEffects is set on the Environment resource and when it's set on the current Camera3D node.
Note that this also disables autoexposure while debug draw is active, but not the manual exposure multiplier. We could look into forcing this multiplier to be 1.0
when a debug draw mode is enabled. This already seems to be in place for the Overdraw debug mode, but not other debug draw modes.
750ab46
to
f2da165
Compare
f2da165
to
c46bb77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. The comments are very helpful and I agree with your assessment
I've flagged this for merging in 4.3 despite it being an enhancement technically. But its a really safe change and only impacts debug drawing. I'm happy to be overruled if others disagree. |
Last force-push was for rebasing on top of master and squashing commits for better integration. |
Thanks! |
Devs for #49696
Bugsquad edit: