Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable camera_effects when debug draw is active #92524

Conversation

ChristopheClaustre
Copy link
Contributor

@ChristopheClaustre ChristopheClaustre commented May 29, 2024

@ChristopheClaustre ChristopheClaustre requested a review from a team as a code owner May 29, 2024 21:25
@akien-mga akien-mga changed the title Disable camera_effects when debug draw is active (issue #49696) Disable camera_effects when debug draw is active May 29, 2024
@akien-mga akien-mga added this to the 4.x milestone May 29, 2024
@ChristopheClaustre ChristopheClaustre force-pushed the disable_camera_effects_when_debug_draw_is_active branch from 4e9da84 to 49c769b Compare June 11, 2024 10:01
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with Forward+ and Mobile (rebased on top of master 292e50e), it works as expected. Since this is done at a server level, this works both in the scenario where CameraEffects is set on the Environment resource and when it's set on the current Camera3D node.

Note that this also disables autoexposure while debug draw is active, but not the manual exposure multiplier. We could look into forcing this multiplier to be 1.0 when a debug draw mode is enabled. This already seems to be in place for the Overdraw debug mode, but not other debug draw modes.

@ChristopheClaustre ChristopheClaustre force-pushed the disable_camera_effects_when_debug_draw_is_active branch 2 times, most recently from 750ab46 to f2da165 Compare June 13, 2024 22:08
@ChristopheClaustre ChristopheClaustre force-pushed the disable_camera_effects_when_debug_draw_is_active branch from f2da165 to c46bb77 Compare June 19, 2024 14:46
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. The comments are very helpful and I agree with your assessment

@clayjohn clayjohn modified the milestones: 4.x, 4.3 Jun 19, 2024
@clayjohn
Copy link
Member

I've flagged this for merging in 4.3 despite it being an enhancement technically. But its a really safe change and only impacts debug drawing. I'm happy to be overruled if others disagree.

@ChristopheClaustre
Copy link
Contributor Author

Last force-push was for rebasing on top of master and squashing commits for better integration.

@akien-mga akien-mga merged commit 191c333 into godotengine:master Jun 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@ChristopheClaustre ChristopheClaustre deleted the disable_camera_effects_when_debug_draw_is_active branch June 22, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan: "Display unshaded" option still shows camera effects such depth of field
4 participants