Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak property name style selector in the editor inspector #92665

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 1, 2024

A preview is now displayed in the options' text:

  • Raw (e.g. "z_index")
  • Capitalized (e.g. "Z Index")
  • Localized (e.g. "Z Index")
    • "Z Index" is localized in the user's language.

@Calinou Calinou added this to the 4.x milestone Jun 1, 2024
@Calinou Calinou requested a review from a team as a code owner June 1, 2024 23:15
@Calinou Calinou force-pushed the editor-inspector-tweak-property-name-selector branch from 4eb8708 to d7e04f0 Compare June 1, 2024 23:16
editor/inspector_dock.cpp Outdated Show resolved Hide resolved
@KoBeWi
Copy link
Member

KoBeWi commented Jun 2, 2024

Not sure if untranslated "(like_this)" is going to be clear. Maybe it could use an existing property name as example.

@akien-mga
Copy link
Member

Yeah I thought the same, though it would likely require adding an explicit "e.g.", for example Raw (e.g. "z_index"). (And thus make the whole string translatable with a comment that z_index should be kept as is.)

@Calinou Calinou force-pushed the editor-inspector-tweak-property-name-selector branch from d7e04f0 to 5a907bd Compare June 18, 2024 22:13
@Calinou
Copy link
Member Author

Calinou commented Jun 18, 2024

Yeah I thought the same, though it would likely require adding an explicit "e.g.", for example Raw (e.g. "z_index"). (And thus make the whole string translatable with a comment that z_index should be kept as is.)

Done (see PR description).

editor/inspector_dock.cpp Outdated Show resolved Hide resolved
A preview is now displayed in the options' text:

- Raw (e.g. "z_index")
- Capitalized (e.g. "Z Index")
- Localized (e.g. "Z Index")
  - "Z Index" is localized in the user's language.
@Calinou Calinou force-pushed the editor-inspector-tweak-property-name-selector branch from 5a907bd to 010d02a Compare June 19, 2024 22:28
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 20, 2024
@akien-mga akien-mga merged commit 82d90f1 into godotengine:master Jun 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-inspector-tweak-property-name-selector branch June 20, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants