CI: Make local python hooks multi-platform #92697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @chrisl8, could you test this one too? |
|
It works! Tried it on Windows 11 and it works great now! I also tried it on macOS and a couple of Linux's just for good measure. They all appear to work fine as well. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #90634, #90662, #92556
After more digging on trying to get to the bottom of this issue, it turns out I was just dumb. pre-commit already converts the
pythonargument to the relevant, isolated python version! This information never cropped up for us because we just so happened to try every possible combination OTHER than:python path/to/script.py. Whoops! 🫠By changing every
python3topython, the hooks now work as expected on every single platform. This also includes defining the default python version like #90662, thedoc-status.pyfix from #92556, and a few formatting tweaks to existing hooks.