Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove note about night sky in PhysicalSkyMaterial #92758

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Remove note about night sky in PhysicalSkyMaterial #92758

merged 1 commit into from
Jun 7, 2024

Conversation

ttencate
Copy link
Contributor

@ttencate ttencate commented Jun 4, 2024

A night sky texture has been supported for quite some time now: #38791 So the instruction to use your own shader for this seems to be outdated.

@ttencate
Remove note about night sky in PhysicalSkyMaterial
6e45eb9 
A night sky texture has been supported for quite some time now: godotengine#38791 So the instruction to use your own shader for this seems to be outdated.
@ttencate ttencate requested a review from a team as a code owner June 4, 2024 13:34
@AThousandShips AThousandShips requested a review from a team June 4, 2024 13:49
@AThousandShips AThousandShips added this to the 4.x milestone Jun 4, 2024
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jun 4, 2024
fire
fire approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the night shader does exist, I can see how this removal makes sense.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 5, 2024
@akien-mga akien-mga merged commit f5c571a into godotengine:master Jun 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@ttencate @akien-mga @fire @Calinou @AThousandShips