Fix editor screenshots menu button's tooltip

[WhalesState]

No description provided.

[AThousandShips]

This breaks at least workflow compatibility, I'd argue this requires a proposal to discuss if this is a good idea in the first place

[WhalesState]

This breaks at least workflow compatibility, I'd argue this requires a proposal to discuss if this is a good idea in the first place

We can just save them separately in the editor data folder, the issue is that it's saving to the project data folder, while only running games should save there, not the editor.

[AThousandShips]

My bad you didn't mention this was not the intended behavior, based on the tooltips

However it still needs to be discussed and breaks workflows that rely on the position

[WhalesState]

Ok, i will just fix the path without making a separate folder for them.

[AThousandShips]

The separate folder isn't the point for that part, you still are moving them to an entirely different path that's what breaks workflows

[AThousandShips]

For context this was added in:

• Add editor screenshot on control - f12. #27510

Where the placement was decided and the tooltip was added, so I suspect the choice of tooltip and path was intentional and the "Editor Data/Settings" part isn't a confusion over that, so I marked this back as an enhancement as it was never intended to work any other way from the start, so should be taken with more care IMO

[AThousandShips]

The more I think about this the more I'm against this change, the current behavior makes it easy to handle screenshots from different projects, the main use of these screenshots are for tutorials, this way you can organize them easily if you're working on different tutorials at once, for example if you spend some time working on the example data etc. and you screenshot each step and you do all the stages (especially if you, for example, record it as a video as well) and then you write up and use the screenshots at the end of the day

Now with these changes the screenshots will be in one grouped folder with no indication which is from which project

I'd say the proper change here is to fix the tooltip, as it was confused in what it said, whereas the location for the screenshot was intended from the start, it also changes a specific detail that has been in the engine since before 4.0, and will now differ between this and past versions (this is IMO not a valid change to cherry pick)

So I'd suggest opening a proposal, and I'd suggest the following:

• Make it configurable
• Expose a screenshot path in the editor paths
• Have it be a project specific setting but based on an editor setting by default
• Keep the current default for this setting

For this PR I'd say to just fix the tooltip

[WhalesState]

At least we know that such confusion exists.

I have a question, shouldn't we considered this as deprecated in 4.x? since it's only capturing the main Editor window and not the whole screen. It can't include opened menus, or other sub-windows, and the shortcut doesn't work if another window is focused ie. popups.

[AThousandShips]

I have a question, shouldn't we considered this as deprecated in 4.x? since it's only capturing the main Editor window and not the whole screen. It can't include opened menus, or other sub-windows, and the shortcut doesn't work if another window is focused ie. popups.

I'd say that's something to also discuss in a proposal

[AThousandShips]

LGTM but needs some editor people reviews as well for specifics

[akien-mga]

IMO the location where screenshots are saved is unexpected, so we should consider changing it. I'm not sure what's the best location but the project-specific user:// folder isn't it.

But for now it makes sense to document this better for 4.3, and evaluate changing it for a future release.

[WhalesState]

IMO, the best location is in editor data folder, we can create a new folder "Screenshots" and we save the screenshots there like ProjectName + "_screenshot_" + Time, this will make it easier to sort them.

[akien-mga]

Thanks!