Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Change the way doNotStrip is set #92859

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

Summersay415
Copy link
Contributor

@Summersay415 Summersay415 commented Jun 7, 2024

Update how doNotStrip is set by leveraging the project's extra properties.

See https://docs.gradle.org/current/javadoc/org/gradle/api/Project.html#properties for reference.

Fixes #92858

@m4gr3d
Copy link
Contributor

m4gr3d commented Jun 8, 2024

@Summersay415 Can you link to the documentation for your change.

@Summersay415
Copy link
Contributor Author

Documentation of Godot or Gradle?
If Godot, then here

@m4gr3d
Copy link
Contributor

m4gr3d commented Jun 8, 2024

Documentation of Godot or Gradle? If Godot, then here

Documentation for gradle; from a quick google search, I cannot find any references to project.ext.doNotStrip.

@Summersay415
Copy link
Contributor Author

Summersay415 commented Jun 9, 2024

This way property are added to the project to be detected by

ext.shouldNotStrip = { ->
    return isAndroidStudio() || project.hasProperty("doNotStrip")
}

Previous way of adding doNotStrip property didn't work and shouldNotStrip returned false even in dev build. This way of setting property works properly and symbols are saved in resulting template

@Summersay415 Summersay415 marked this pull request as draft June 17, 2024 11:54
@Repiteo Repiteo modified the milestones: 4.3, 4.4 Jul 24, 2024
@m4gr3d m4gr3d marked this pull request as ready for review July 28, 2024 15:08
@m4gr3d
Copy link
Contributor

m4gr3d commented Jul 28, 2024

Sorry for the delay on this PR. I was able to confirm your fix is correct by checking the following documentation:

https://docs.gradle.org/current/javadoc/org/gradle/api/Project.html#properties

I've updated the PR's description to match.

Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@m4gr3d m4gr3d modified the milestones: 4.4, 4.3 Jul 28, 2024
@akien-mga akien-mga changed the title Change the way doNotStrip is set Android: Change the way doNotStrip is set Jul 28, 2024
@akien-mga akien-mga merged commit 1d8373a into godotengine:master Jul 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle strips debug symbols even in dev build
5 participants