Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix description for Input.vibrate_handheld() #92860

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix description for Input.vibrate_handheld() #92860

merged 1 commit into from
Jun 12, 2024

Conversation

timothyqiu
Copy link
Member

  • It's weird to put a "note" about a parameter on the very first line.
  • Fixed markup for the parameter name and constant values.
  • Adjusted wording so we explain what the parameter does first.

@timothyqiu timothyqiu added this to the 4.3 milestone Jun 7, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner June 7, 2024 08:08
AThousandShips
AThousandShips approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't confirm the factual correctness but the language is good and clear!

Mickeon
Mickeon reviewed Jun 7, 2024
View reviewed changes
doc/classes/Input.xml Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 7ec0bc5 into godotengine:master Jun 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the amplitude branch June 12, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@Mickeon Mickeon Mickeon approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@timothyqiu @akien-mga @Mickeon @AThousandShips