Core: Integrate Ref instantiate where possible
#92986
Open
+81
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Jun 10, 2024
Repiteo
force-pushed
the
core/ref-instantiate-integration
branch
from
1954300
to
e2fd2ce
Compare
Repiteo
force-pushed
the
core/ref-instantiate-integration
branch
from
e2fd2ce
to
a3e7aa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #88183, which expanded
Ref<T>::instantiate()to accept constructor arguments. This PR is focused on converting existing Ref constructors to the shorthand syntax where applicable. Does not convert every instance, as some constructors happen on the same line a Ref is declared; converting these would require a static method, and is more suitable as a separate PR.