Fix Left Joystick motion not registering on Android #93011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTareqAzim
force-pushed
the
fix-android-motion-event-guards
branch
from
18512bb
to
4450983
Compare
|
Wait, I realized one mistake where I don't keep parity with the previous structure. |
MTareqAzim
force-pushed
the
fix-android-motion-event-guards
branch
from
4450983
to
d14bea4
Compare
|
Hopefully this keeps parity with the initial intent of the code. Any joystick motion event from a non-existent device should return false as it did previously, but expedited now. |
m4gr3d
approved these changes
Jun 12, 2024
|
Thanks! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change made in commit ab9e377, left joystick motion inputs don't get properly registered. I reordered the guards in the
onGenericMotionEvent()function so that joystick inputs don't get sent to theGodotGestureHandlerin the first place.I believe the
GodotGestureHandlershould not have to make an exception for that one function and do an event source check. Every other function in it is able to assume only the events with the proper sources are sent to it. However, a maintainer with a better overview of the systems should give their opinion.Fixes #92939