-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Container
pending_sort and "Saving Scene" ProgressDialog
size.
#93030
Conversation
I'm confused, we already merged fixes for these issues. Your branch seems to be based off an earlier version of the |
I have restored the branch after deletion, then i pressed update branch because it was already merged before so there was no commits ahead master, and when i opened the branch i didn't find the changes was reverted, so i just pressed undo last commit and i force pushed the changes. I also was confused because the last commit wasn't my fix, there was like 60 other commits. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
fdb3a69
to
a8797e3
Compare
a8797e3
to
d8190b7
Compare
I can't reproduce #92971, seems like it only happens with I have tried the same code in |
Sorry about the confusion, I just thought my fix was reverted because i used to see that happens when a pull request causes regression. |
Nothing, I reproduced the issue with this script to understand, Sorry -_- extends Control
func _ready():
var container = Container2.new()
container.set_anchors_and_offsets_preset(PRESET_FULL_RECT)
var popup := PopupPanel.new()
popup.exclusive = true
add_child(popup)
popup.add_child(container)
popup.size = Vector2(340, 256)
popup.popup_centered()
popup.hide()
popup.remove_child(container)
await get_tree().create_timer(1).timeout
popup.add_child(container)
popup.popup_centered()
class Container2:
extends VBoxContainer
func _init():
for i in range(5):
var button = Button.new()
button.text = "Button %s" % i
add_child(button)
|
Fixes: #92971
Since both issues are closed, and each one produces the other, it's better to fix both at the same time.If this ever leads to any other issues that can't be fixed by deferring a sort children notification call, please tag me.