[X11] Detect XWayland and disable screen capture support. #93072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on XWayland (Fedora 40 KDE on Wayland) with multi window mode, it seems to fall back to the legacy app window color picker, which seems to be a good compromise.
In windowed mode, the background of the window turns black:
|
akien-mga
approved these changes
Jun 12, 2024
|
Tested on Wayland with the Wayland display driver, there it looks a bit better:
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
XGetImageon XWayland either cause error spam, or crash app, or crash the whole Wayland session.Fixes #91632
Fixes #88550, at least when running in single window mode (will use app legacy app window color picker), multi window mode is completely unusable on XWayand and was not tested.