OpenXR: Add HTC/MSFT hand interaction profiles #93075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
I haven't tested, or double checked the data on the spec, but this looks good at a glance!
Given that it's just registering metadata about new "controller" types, I personally think it should be fine to sneak into 4.3, or in worst case, cherry-picked into 4.3.1.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds profiles for the HTC hand interaction and MSFT hand interaction. This in lieu of adoption of the EXT hand interaction extension in OpenXR.
Specifically the MSFT hand interaction makes better mixed controller and hand tracking support possible on several devices including the Quest.
While new logic, this is hopefully small enough to still be considered for 4.3.
See godotengine/godot-demo-projects#973 for a demo project.