[Window] Ignore duplicate mouse enter events. #93100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jun 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93085
Alternatively, #92908 code can be moved to the macOS
DisplayServer, but this will require more complicated checks (actually tracking is event was received by Widows), and might require the same changes on other platforms (I can't reproduce it on Windows or Linux, but system events timing can be inconsistent).Receiving a duplicate enter event for the same window and ignoring it should not have any negative effects, not receiving it at all will break UI, so it is a safer option. The original check which was showing a warning is preserved (it is supposed to warn if different window get enter event without previously hovered window getting exit event first and still serve this purpose).