Fix issues related to code-signing for macOS exports #93101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues related to code-signing macOS exports:
*.framework
, you will currently see error messages aboutMachO: Can't open file: [...]
due to certain places inEditorExportPlatformMacOS
assuming that all extensions are files, whereas*.framework
is a directory.*.framework
, you will currently end up with a bunch of errors aboutLipO: Can't open file: [...]
due to Godot thinking that theResources
directory is a bundle directory. This seemed to be the result of the regular expressions in_codesign_file
not accounting for the slash at the end being optional for theResources
directory.*.framework
bundle layout with which I distribute Godot Jolt currently, where I don't have aVersions
directory (since I can't reasonably distribute symlinks) but instead just the binary and aResources
directory at the top-level. While this layout probably raises some eyebrows, it works just fine with regularcodesign
as well asnotarytool
, so I don't see why Godot shouldn't support it too.CC @bruvzg