Fix crash when trying to undo SpriteFrames animation rename #93112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr also fixes #92600 |
KoBeWi
reviewed
Jun 13, 2024
KoBeWi
approved these changes
Jun 13, 2024
|
Thanks! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93079
Bugsquad edit: Also fixes #92600
The problem was introduced by PR #90815. As suggested by KoBeWi in that PR, I modified the verification to check if the new SpriteFrames is different. I removed the method
is_editingbecause I found it redundant withget_sprite_frames.Tested with renaming animations, Ctrl-Z, adding animations, and removing animations.