[Image Font Importer] Adds support for \uXXXX in the kerning config strings.
#93119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jun 13, 2024
|
Thanks! |
DarkMarmot
reviewed
Jun 27, 2024
| for (int i = 0; i < kp_tokens[0].length(); i++) { | ||
| if (i <= kp_tokens[0].length() - 6 && kp_tokens[0][i] == '\\' && kp_tokens[0][i + 1] == 'u') { | ||
| char32_t charcode = kp_tokens[0].substr(i + 2, 4).hex_to_int(); | ||
| from_tokens += charcode; |
There was a problem hiding this comment.
@bruvzg This bit of code is missing a part to advance past the hex characters and thus includes u and whatever 4 hex characters are included after it. I think it just needs i += 5 here and in the next loop set to fix it. Do I need a demo project for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #93066
Spaces can be now added to kerning pairs with
\u0020, not the most elegant solution, but not much can be changed without breaking existing imports.I'll probably make a separate PR adding the advanced import dialog for bitmap fonts, since entering it via standard property editor is not convenient.