ResourceLoader: Let the caller thread use its own message queue override
#93124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…den in a task Also, simplifies the thread override teardown in MessageQueue.
akien-mga
approved these changes
Jun 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for extra flexibility in certain (advanced) use cases, where the user may want to exert greater control over the "queued-update-like" actions happening during resource loading. These advanced APIs are not exposed yet, though. Also, this is also a fix as there's no notion of a stack of call queue overrides that can be pushed and popped, and
ResourceLoaderwould otherwise be recklessly overriding any currently set, reverting back to the main queue otherwise.The change has a base commit that fixes the fact that the
WorkerThreadPoolwasn't considering the thread call queue override as part of the thread-wide state to restore in case a task has overridden it. Such commit is a bugfix by itself as well.