Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Fix some invalid error messages #93135

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[Tests] Fix some invalid error messages #93135

merged 1 commit into from
Jul 10, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Jun 13, 2024 •
edited
Loading

These used utf8().get_data() when they should be passed as String

Otherwise the specific warning won't be printed

@AThousandShips AThousandShips added bug topic:tests cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jun 13, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jun 13, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner June 13, 2024 17:55
@AThousandShips AThousandShips mentioned this pull request Jun 13, 2024
Merged
@AThousandShips AThousandShips modified the milestones: 4.3, 4.4 Jun 28, 2024
@AThousandShips AThousandShips added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jun 28, 2024
@AThousandShips
[Tests] Fix some invalid error messages
ea2e6be 
These used `utf8().get_data()` when they should be passed as `String`
@akien-mga akien-mga modified the milestones: 4.4, 4.3 Jul 10, 2024
@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jul 10, 2024
@akien-mga akien-mga merged commit 7f7ea48 into godotengine:master Jul 10, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the test_string_fix branch July 11, 2024 07:50
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geometror Geometror Geometror approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:tests
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @akien-mga @Geometror