Prevent node rename shortcut from stealing focus from controls

[passivestar]

Adds a check for controls that may react to Enter to prevent a conflict on macOS. Fixes #88102

[ajreckof]

This is something that has been a huge pain for quite some time. I haven't tested it but code looks good.

[KoBeWi]

The bug only occurs, because the default shortcut uses Enter. You can reproduce it on other systems if you manually assign Enter shortcut for renaming or other action. I wonder if other docks are affected too (considering non-default shortcuts).

I think instead of checking for Range you could add is_text_field() to EditorSpinSlider.

[passivestar]

I wonder if other docks are affected too

Nope, no other dock reacts to enter like this

I think instead of checking for Range you could add is_text_field() to EditorSpinSlider

Seems reasonable

[KoBeWi]

This makes SceneTree shortcuts unusable when a Button is focused. Not sure if it's a problem though, as editor viewports can steal focus very easily so it shouldn't be noticeable.

[passivestar]

Now only the rename shortcut is prevented if a button is focused

[KoBeWi]

That's... very specific 🙃
The issue only exists because of a default shortcut. Shortcuts are rebindable, so it doesn't solve all problems.
But eh, technically it fixes the linked issue.

[passivestar]

It is very specific and the code is not as pretty :). But previous code didn't make sense though... Blocking all shortcuts seems excessive, even if it's a rare encounter it doesn't feel good if nothing happens when you press a shortcut. If user rebinds to conflicting shortcuts it's a different story I think

[akien-mga]

Thanks!