Fix ruler tool sticks after right click

[MannyFluss]

ruler tool prevents new nodes from being added while ruler is active.

• Bugsquad edit, fixes: Ruler tool stuck after right click #93043

[AThousandShips]

Please make the PR title more descriptive, describing what you have done instead of what issue number you have fixed

[Chaosus]

@AThousandShips Hm, fox? Maybe fix?

[AThousandShips]

Autocorrect strikes again!

[KoBeWi]

I think right click should cancel the operation instead of doing nothing.

[MannyFluss]

should it allow the add child popup menu to appear or just cancel the ruler

[KoBeWi]

Just cancel.

[KoBeWi]

Remember to squash the commits into 1.

[MannyFluss]

how do I squash the commits into one? or is that for someone else to do.

[KoBeWi]

See https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase

[MannyFluss]

for future reference, should I should be using amends for small changes like this?

[KoBeWi]

Having multiple commits make it easier to follow changes, but more difficult to resolve conflicts. At the end you are expected to squash into single commit anyway, so use what works better for you.
Also it's better to avoid accepting changes or rebasing using the GitHub buttons, because they make the PR more difficult to squash.

[MannyFluss]

I have learned a lot from this, hopefully next pr I do goes a bit smoother! (also hopefully i didnt just jynx it)

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉