Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parallax2D repeats in ysort child collection #93182

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add Parallax2D repeats in ysort child collection #93182

merged 1 commit into from
Jun 17, 2024

Conversation

markdibarry
Copy link
Contributor

@markdibarry markdibarry commented Jun 14, 2024 •
edited
Loading

Y-sort flattens the tree branch, so repeat data isn't passed along. This adds it back.
Thanks @kleonc for the catch and advice!

Fixes: #93181

2024-06-14.17-33-44.mp4

@markdibarry markdibarry requested a review from a team as a code owner June 14, 2024 21:42
@markdibarry markdibarry mentioned this pull request Jun 14, 2024
Merged
@kleonc kleonc added this to the 4.3 milestone Jun 15, 2024
kleonc
kleonc reviewed Jun 15, 2024
View reviewed changes
servers/rendering/renderer_canvas_cull.cpp Outdated Show resolved Hide resolved
servers/rendering/renderer_canvas_cull.cpp Outdated Show resolved Hide resolved
servers/rendering/renderer_canvas_cull.cpp Outdated Show resolved Hide resolved
servers/rendering/renderer_canvas_cull.cpp Outdated Show resolved Hide resolved
servers/rendering/renderer_canvas_cull.cpp Outdated Show resolved Hide resolved
kleonc
kleonc approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@kleonc kleonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Now canvas items should end up with the same repeat_size and repeat_times regardless of whether they are y-sorted or not. 👍

@akien-mga akien-mga merged commit 47d778e into godotengine:master Jun 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@markdibarry markdibarry deleted the parallax2d-y-sort-fix branch June 18, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleonc kleonc kleonc approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Parallax2D repeats disappear with y-sort enabled
3 participants
@markdibarry @akien-mga @kleonc