Fix description of Vector2/3.dot

[shak2]

Corrected mathmatical language - Straight angle is 180 degrees. Right angle is 90 degrees.

[AThousandShips]

Please update your commit to have a more descriptive message, like the title of the PR

This will also need to be done for Vector2

[AThousandShips]

If you need help with fixing the commit please ask

[shak2]

You fixed the commit title, then asked for the commit title to be changed. I am new and not sure what this all means.

Please auto fix all that needs fixing, thanks.

[AThousandShips]

The commit hasn't changed, you updated the description of the commit, and I updated the title of the PR (that's why i asked you to match it after I fixed the title)

If you're unsure how to do something please say so, it's impossible to tell that you don't know what I'm talking about without you saying so

I'll update your commit for you but in the future please do so yourself, and ask if you need instructions for how to do it (it's not auto fixing I have to do so manually)

[AThousandShips]

There fixed! But in the future please use the command line or desktop version to make updates and edits, see here

[shak2]

Last question: I don't understand this:

"The commit hasn't changed, you updated the description of the commit, and I updated the title of the PR (that's why i asked you to match it after I fixed the title)"

and

"Please update your commit to have a more descriptive message, like the title of the PR"

I am not sure what should have matched what here? should the description match the title? Is pr title different from the commit title and those were not matching?

I just followed the web UI process...

[AThousandShips]

The commit message is the thing that's above my earlier message that says 451d099 at the end, you didn't change that by updating the branch on your fork of godot, there are:

• The PR title (that's at the top of the page)
• The PR description (the "Corrected mathmatical language - Straight angle is 180 degrees. Right angle is 90 degrees.") part
• The commit message, which is separate

It's okay, but we prefer not using the web UI because it's very limited and you should instead use the desktop feature (see the instructions above) for your contributions

At least the title of the commit (when you press the "Commit changes..." when editing) should be a good description and not just the "Updated FILE" :)

But the most important lesson for the future is:

• If you don't understand an instruction or feedback, ask!

[timothyqiu]

The dot product will be [code]0[/code] for a straight angle (90 degrees), greater than 0 for angles narrower than 90 degrees and lower than 0 for angles wider than 90 degrees.

I think the original wording can be simplified. It mentions and explains "a right angle", but uses degrees directly for acute and obtuse angles.

Either

The dot product will be [code]0[/code] for a 90-degree angle, greater than 0 for angles narrower than 90 degrees and lower than 0 for angles wider than 90 degrees.

or

The dot product will be [code]0[/code] for a right angle (90 degrees), greater than 0 for acute angles (narrower than 90 degrees) and lower than 0 for obtuse angles (wider than 90 degrees).

looks better.

[AThousandShips]

Let's do that in a follow up though

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉