Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make profiling_get_frame_data call the correct GDVIRTUAL method #93281

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Make profiling_get_frame_data call the correct GDVIRTUAL method #93281

merged 1 commit into from
Jun 18, 2024

Conversation

TitanNano
Copy link
Contributor

ScriptLanguageExtension::profiling_get_frame_data is currently calling _profiling_get_accumulated_data while it most likely should be calling the GDVIRTUAL method _profiling_get_frame_data with the same name.

@TitanNano TitanNano requested a review from a team as a code owner June 17, 2024 22:57
@AThousandShips AThousandShips added this to the 4.3 milestone Jun 18, 2024
dsnopek
dsnopek approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks correct to me. It was probably a copy-paste mistake originally :-)

@dsnopek dsnopek requested a review from a team June 18, 2024 15:28
@akien-mga akien-mga changed the title Make profiling_get_frame_data call the correct GDVIRTUAL method Make profiling_get_frame_data call the correct GDVIRTUAL method Jun 18, 2024
@akien-mga akien-mga merged commit a492b32 into godotengine:master Jun 18, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@TitanNano TitanNano deleted the jovan/fix_get_frame_data branch June 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug topic:gdextension
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanNano @akien-mga @dsnopek @AThousandShips