Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SurfaceTool::generate_tangents UV error message #93326

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Maski0
Copy link
Contributor

@Maski0 Maski0 commented Jun 18, 2024

Fixes #92395
Simple change ERR_FAIL_COND macro to ERR_FAIL_COND_MSG to add in a Clear message of why the error occurred.

@AThousandShips AThousandShips added this to the 4.x milestone Jun 18, 2024
@AThousandShips AThousandShips changed the title fixes #92395 Simple expand of the error with clear problem message improve SurfaceTool::generate_tangents UV error message Jun 18, 2024
@akien-mga akien-mga changed the title improve SurfaceTool::generate_tangents UV error message Improve SurfaceTool::generate_tangents UV error message Jun 18, 2024
@clayjohn clayjohn modified the milestones: 4.x, 4.3 Jun 19, 2024
@akien-mga akien-mga merged commit 2c5145f into godotengine:master Jun 20, 2024
14 of 15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Maski0
Copy link
Contributor Author

Maski0 commented Jun 20, 2024

Thanks! I'm glad I could be of some help. I hope to contribute more in the future.

@Maski0 Maski0 deleted the #92395 branch June 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty mesh causes SurfaceTools::generate_tangents to fail an assertion which doesn't make sense.
5 participants