Make AnimationTrackCaches invalid when animation is added #93505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
changed the title
TokageItLab
force-pushed
the
disable-cache-when-adding-animation
branch
from
d742b1a
to
e82ec1a
Compare
akien-mga
approved these changes
Jun 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/godotengine/godot/pull/86715/files#diff-8e8def668b2df75cec75f2dc07225717bdeebe58daad5fbf3fad3dfab101f64fL420 makes it so that the cache is not deleted more than necessary when playing back animations, but does nothing about the cache when animations are added, so the track cache is not generated for the added animations. In this case, it is not necessary to delete the cache, but it is necessary to trigger an update.