Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XR: Check for bad input in make_vrs_texture #93536

Merged
merged 1 commit into from
Jun 24, 2024
Merged

XR: Check for bad input in make_vrs_texture #93536

merged 1 commit into from
Jun 24, 2024

Conversation

BastiaanOlij
Copy link
Contributor

This adds some checks in case XRVRS::make_vrs_texture is called in a situation that it can't work or if input info is unusable.

@BastiaanOlij BastiaanOlij requested a review from a team as a code owner June 24, 2024 06:38
AThousandShips
AThousandShips reviewed Jun 24, 2024
View reviewed changes
servers/xr/xr_vrs.cpp Outdated Show resolved Hide resolved
servers/xr/xr_vrs.cpp Outdated Show resolved Hide resolved
servers/xr/xr_vrs.cpp Outdated Show resolved Hide resolved
@AThousandShips AThousandShips added this to the 4.3 milestone Jun 24, 2024
akien-mga
akien-mga approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, pending style fixes.

@akien-mga akien-mga changed the title Check for bad input in make_vrs_texture XR: Check for bad input in make_vrs_texture Jun 24, 2024
@akien-mga akien-mga merged commit f99c7e9 into godotengine:master Jun 24, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_make_vrs_ci branch July 2, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@m4gr3d m4gr3d m4gr3d approved these changes

@akien-mga akien-mga akien-mga approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:xr
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Executing XRVRS.make_vrs_texture function crashes Godot
5 participants
@BastiaanOlij @akien-mga @dsnopek @m4gr3d @AThousandShips