Fix reselecting scene tree node after inspecting a resource #93543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke when the `node_selected` connection was removed in godotengine#91435. Here it's returned, but the emit is removed from `_node_removed`. That preserves the earlier fix while allowing nodes to be reselected.
KoBeWi
approved these changes
Jun 24, 2024
ajreckof
approved these changes
Jun 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke when the
node_selectedconnection was removed in #91435. Here it's returned, but the emit is removed from_node_removed. That preserves the earlier fix while allowing nodes to be reselected.Fixes #93534.
I'm not confident that I didn't break something else with this fix, but so far I haven't found any problems.