Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add editor target to Android builds config #93553

Merged
merged 1 commit into from
Jun 27, 2024
Merged

CI: Add editor target to Android builds config #93553

merged 1 commit into from
Jun 27, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jun 24, 2024

The configuration was updated to generate:

  • Godot Android Editor build
  • Godot Android template build for arm32
  • Godot Android template build for arm64

@m4gr3d m4gr3d added this to the 4.3 milestone Jun 24, 2024
@m4gr3d m4gr3d requested a review from akien-mga June 24, 2024 13:23
@m4gr3d m4gr3d requested a review from a team as a code owner June 24, 2024 13:23
akien-mga
akien-mga approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

As discussed on RC, this adds one extra build to our CI build matrix, but since it's a Linux-based runner and we have a good concurrency there (the bottleneck is on macOS runners), it should be ok.

.github/workflows/android_builds.yml Outdated Show resolved Hide resolved
@m4gr3d @akien-mga
Update the github Android builds config
8026706 
The configuration was updated to generate:
- Godot Android Editor build
- Godot Android template build for arm32
- Godot Android template build for arm64

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
@m4gr3d m4gr3d force-pushed the update_github_android_build_config branch from a656323 to 8026706 Compare June 26, 2024 19:44
@akien-mga akien-mga changed the title Update the github Android builds config Update the GitHub CI Android builds config Jun 27, 2024
@akien-mga akien-mga changed the title Update the GitHub CI Android builds config CI: Add editor target to Android builds config Jun 27, 2024
@akien-mga akien-mga merged commit 48973aa into godotengine:master Jun 27, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the update_github_android_build_config branch June 27, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:buildsystem
Projects
4.x Release Blockers
Status: Not Critical
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@m4gr3d @akien-mga