Prevent folder names with trailing periods from being used automatically #93564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dumb question, what about MacOS or any other build of the engine? Is the trailing period already trimmed, or is it plainly allowed? Or does this PR already catch all of them? |
It's not currently trimmed in
|
aaronfranke
approved these changes
Jun 25, 2024
AThousandShips
approved these changes
Jun 25, 2024
akien-mga
reviewed
Jun 26, 2024
Folder names ending with one or more `.` characters are not allowed on Windows, so this would break writing logs, shader cache and other project-specific files. Trailing periods are now stripped in this case. On non-Windows platforms, this change still applies in the interest of portability.
Calinou
force-pushed
the
project-user-dir-prevent-trailing-periods
branch
from
bd2709d to
492787b
Compare
akien-mga
approved these changes
Jun 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folder names ending with one or more
.characters are not allowed on Windows, so this would break writing logs, shader cache and other project-specific files. Trailing periods are now stripped in this case.On non-Windows platforms, this change still applies in the interest of portability.
This is technically a small breakage on non-Windows platforms because of this, but very few projects had user directory names that ended with
.anyway (as it didn't work on Windows).Testing project: test_project_periods.zip