Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment for editor particles Restart Emission shortcut not using Cmd on macOS #93581

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 24, 2024

This is done to avoid a conflict, but it's not obvious when looking at the code.

@passivestar
Copy link
Contributor

I'm afraid that one is taken

Screenshot 2024-06-25 at 03 48 41

Ctrl+R to restart particles is completely fine 🙂

…Cmd on macOS

This is done to avoid a conflict, but it's not obvious when looking
at the code.
@Calinou Calinou force-pushed the editor-particles-restart-fix-shortcut branch from cd052b2 to 555f0aa Compare June 25, 2024 00:22
@Calinou
Copy link
Member Author

Calinou commented Jun 25, 2024

I'm afraid that one is taken

Right, and Run Current Scene isn't Ctrl + R on macOS platforms.

I've amended the PR to only add a comment above the existing code, so there's behavior change now.

@Calinou Calinou changed the title Fix editor particles Restart Emission shortcut not using Cmd on macOS Add comment for editor particles Restart Emission shortcut not using Cmd on macOS Jun 25, 2024
@akien-mga akien-mga merged commit 066555f into godotengine:master Jun 25, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-particles-restart-fix-shortcut branch June 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants