Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeEdit: Fix move lines up/down viewport and selection issues #93607

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Jun 25, 2024

Also fixes some edge cases I found when testing.

  • Move lines up/down at the top/bottom when the selection ends at column 0 should not change the selection.
  • Move lines up or down when a selection ends at column 0 and there is another selection on that line adjusted the selection incorrectly.
  • Move lines down when a selection ends at column 0 and there is a selection on the next line adjusted the selection incorrectly.
  • Added tests for these.
  • Added tests for unfolding when moving lines up or down.

@kitbdev kitbdev requested review from a team as code owners June 25, 2024 19:33
@Chaosus Chaosus added this to the 4.3 milestone Jun 25, 2024
@akien-mga akien-mga changed the title CodeEdit Fix move lines up/down viewport and selection issues CodeEdit: Fix move lines up/down viewport and selection issues Jun 25, 2024
@akien-mga akien-mga merged commit 3f4bcfe into godotengine:master Jun 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the fix-text-edit-move-lines branch June 27, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script editor no longer scrolls when you move line with Alt+Up/Down
3 participants