Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebXR palm joint calculation to include rotation #93614

Merged

Conversation

Malcolmnixon
Copy link
Contributor

The current WebXR palm joint is calculated with a valid position, but with an identity rotation. This PR modifies the calculation so it has the rotation of the middle finger metacarpal bone.

This video shows the fix in action.

Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AThousandShips AThousandShips added this to the 4.3 milestone Jun 26, 2024
@akien-mga akien-mga merged commit 95110dd into godotengine:master Jun 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants