Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RichTextLabel fade set start_index to command offset #93721

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix RichTextLabel fade set start_index to command offset #93721

merged 1 commit into from
Jul 9, 2024

Conversation

semensanyok
Copy link
Contributor

@semensanyok semensanyok commented Jun 28, 2024 •
edited by Calinou
Loading

@semensanyok semensanyok requested a review from a team as a code owner June 28, 2024 21:16
@Calinou Calinou added this to the 4.3 milestone Jun 28, 2024
@Calinou Calinou changed the title #93700 fix RichTextLabel fade set start_index to command offset Fix RichTextLabel fade set start_index to command offset Jun 28, 2024
anniryynanen
anniryynanen reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@anniryynanen anniryynanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reproduced the issue in v4.3.beta2 and confirm that this PR fixes it. Regression risk is close to none.

@akien-mga akien-mga changed the title Fix RichTextLabel fade set start_index to command offset Fix RichTextLabel fade set start_index to command offset Jul 9, 2024
@akien-mga akien-mga added cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release and removed cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 9, 2024
@akien-mga akien-mga merged commit 17e7253 into godotengine:master Jul 9, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anniryynanen anniryynanen anniryynanen left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

RichTextLabel's "fade" offsets from start of string rather than start of command
4 participants
@semensanyok @akien-mga @anniryynanen @Calinou