Make the frame time and info boxes use same margins #93736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passivestar
force-pushed
the
info-panel-margins
branch
from
b676e4a
to
4201c7d
Compare
akien-mga
approved these changes
Jun 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put info label into a panelcontainer so that it has the same margins as the fps box and disable mouse events on both of them (previously you couldn't start orbiting if your cursor happened to be inside of the fps box)
I think a panel container makes sense there assuming the info panel might need more work in the future to better format the existing information and potentially include some new information (which will require more than one label)