Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reimport by scan parsing dependency paths incorrectly #93765

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Jordyfel
Copy link
Contributor

Fix #92250
maybe other reimport related issues?

Resource loader's get_dependencies returns a string in the format uid::type::path (or path::type, or path only), but this code was not taking it into account.

Invalid strings were being passed into the reimport_files function. Since that function supports uids, they are now passed when possible.

The _update_file_icon_path function had no symptoms because of missing script uids, but would break when they are added.

@Jordyfel Jordyfel changed the title Fix reimport parsing dependencies incorrectly Fix reimport by scan parsing dependency paths incorrectly Jun 30, 2024
@fire fire requested a review from a team June 30, 2024 02:51
@passivestar
Copy link
Contributor

Tested, this does solve the issue, the error messages are gone, thanks 💙

@akien-mga akien-mga merged commit 16d549a into godotengine:master Jul 8, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Jordyfel Jordyfel deleted the reimport-dependency-bug branch July 8, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Can't find file" error messages when reimporting a gltf scene
6 participants