Fix info about global library in add_animation_library method docs
#93818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Jul 1, 2024
TokageItLab
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Is there a case where I need to manually add a global library? It seems to me that this is rather a prohibited method with that argument.
AnimationMixer has a global library by default with an empty string as key, so if you want to add an animation to the global library, you can write the following.
var global_lib = mixer.get_animation_library("")
global_lib.add_animation("name", animres)If anything is missing in the documentation, it is this code.
|
So, I should remove the info I added, and instead add this code in the description. Am i right? |
TokageItLab
reviewed
Jul 1, 2024
TokageItLab
approved these changes
Jul 1, 2024
|
Please squash the commits to follow PR workflow https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase |
akien-mga
changed the title
add_animation_library method docs
…classes/AnimationMixer.xml Fix Info about Global library on add_animation_library method in doc/classes/AnimationMixer.xml Fix Info about Global library on add_animation_library method Co-authored-by: Silc Lizard (Tokage) Renew <tokage.it.lab@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information about how to add a Global library is not in the documentation currently.
This PR adds the following information in the add_animation_library method
in doc/classes/AnimationMixer.xml:
"When name is set to an empty string, the Global library is added."