Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for new EditorExportPlugin behavior. #93820

Merged

Conversation

allenwp
Copy link
Contributor

@allenwp allenwp commented Jul 1, 2024

This new skip() behaviour was introduced in #90365. This also fixes some inconsistencies in the docs.

@allenwp allenwp requested a review from a team as a code owner July 1, 2024 16:29
@AThousandShips AThousandShips changed the title Updated documentation for new EditorExportPlugin behaviour. Update documentation for new EditorExportPlugin behavior. Jul 1, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Jul 1, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 1, 2024
@akien-mga akien-mga requested review from KoBeWi and a team July 1, 2024 16:32
@allenwp allenwp force-pushed the EditorExportPlugin-docs-update branch from 1567450 to 444babc Compare July 1, 2024 16:39
@allenwp allenwp marked this pull request as draft July 1, 2024 17:33
@allenwp allenwp force-pushed the EditorExportPlugin-docs-update branch 2 times, most recently from 561f661 to 98c58b3 Compare July 1, 2024 18:59
@allenwp allenwp force-pushed the EditorExportPlugin-docs-update branch from 98c58b3 to 53c536a Compare July 1, 2024 20:36
@allenwp allenwp marked this pull request as ready for review July 1, 2024 20:36
@allenwp allenwp force-pushed the EditorExportPlugin-docs-update branch from 53c536a to 0a4dfc4 Compare July 1, 2024 21:33
doc/classes/EditorExportPlugin.xml Outdated Show resolved Hide resolved
This behaviour was introduced in godotengine#90365. This also fixes some inconsistencies in the docs and adds clarification of how the _export_file function works.
@allenwp allenwp force-pushed the EditorExportPlugin-docs-update branch from 790049f to 32f0b25 Compare July 2, 2024 15:56
@akien-mga akien-mga merged commit 8f749ca into godotengine:master Jul 3, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@allenwp allenwp deleted the EditorExportPlugin-docs-update branch July 7, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants