Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDScript] Fix get_method for lambda self Callables #94076

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[GDScript] Fix get_method for lambda self Callables #94076

merged 1 commit into from
Jul 8, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added bug topic:gdscript cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 8, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jul 8, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner July 8, 2024 14:32
adamscott
adamscott approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, it was a simple oversight.

@dalexeev
Copy link
Member

dalexeev commented Jul 8, 2024

It would be nice to add a test.

@AThousandShips
Copy link
Member Author

I'll make one

@akien-mga akien-mga merged commit 6deaa15 into godotengine:master Jul 8, 2024
18 checks passed
@AThousandShips AThousandShips deleted the lambda_get_method_fix branch July 8, 2024 17:17
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Callable.get_method() does not fully work on lambda functions if they access member variables
4 participants
@AThousandShips @dalexeev @akien-mga @adamscott