Add support for generating LODs and shadow mesh in PrimitiveMesh #94097
+78
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
primitivemesh-add-generate-lod-shadow-mesh
branch
from
051c911
to
8959e3b
Compare
1 task
Calinou
force-pushed
the
primitivemesh-add-generate-lod-shadow-mesh
branch
from
8959e3b
to
b5a1ec7
Compare
Mickeon
reviewed
Jul 9, 2024
This can improve rendering performance with complex meshes, particularly SphereMesh, CapsuleMesh and TorusMesh. This is disabled by default to ensure meshes are created as quickly as possible (and to avoid breaking custom shaders that displace vertices).
Calinou
force-pushed
the
primitivemesh-add-generate-lod-shadow-mesh
branch
from
b5a1ec7
to
afd634a
Compare
|
I'm not sure about this. We really need a use case before implementing something like this. Otherwise we are adding bloat for no benefit. The original proposal is asking for a tessellated mesh resource, that's not what this does. And this doesn't allow the user to do what they are asking to do either. I would wait until a user asks for this with a real use-case before going forward with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can improve rendering performance with complex meshes, particularly SphereMesh, CapsuleMesh and TorusMesh.
This is disabled by default to ensure meshes are created as quickly as possible (and to avoid breaking custom shaders that displace vertices).
Preview
Look at the primitive count in the top-right corner of the editor.
LOD/shadow mesh disabled
LOD/shadow mesh enabled
LOD/shadow mesh enabled (Mesh LOD Threshold = 4 pixels)