Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/node configuration warning dialog text #94147

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fixes/node configuration warning dialog text #94147

merged 1 commit into from
Jul 10, 2024

Conversation

MovaUA
Copy link
Contributor

@MovaUA MovaUA commented Jul 9, 2024 •
edited by akien-mga
Loading

This PR fixes #94145 Incorrect text in the Node Configuration Warning dialog

@MovaUA MovaUA requested review from a team as code owners July 9, 2024 19:11
@MovaUA MovaUA marked this pull request as draft July 9, 2024 19:12
@KoBeWi
Copy link
Member

KoBeWi commented Jul 9, 2024 •
edited
Loading

The translation files should not be modified, the translations will be updated on Weblate.

@MovaUA
Copy link
Contributor Author

MovaUA commented Jul 9, 2024

The translation files should not be modified, the translations will be updated on Weblate.

Oh, thank you, @KoBeWi!

KoBeWi
KoBeWi approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to squash the commits into 1.

@MovaUA MovaUA marked this pull request as ready for review July 9, 2024 20:22
@MovaUA
Copy link
Contributor Author

MovaUA commented Jul 9, 2024

You'll need to squash the commits into 1.

Got it. Thank you!

@MovaUA
Fix Issue #94145 Incorrect text in the Node Configuration Warning dialog
32369d2 
Fix some translations

Revert "Fix some translations"

This reverts commit 61e586ef84fb962eefdc14593241c1d8b0fb7b6b.

Revert "Fix Issue #94145 Incorrect text in the Node Configuration Warning dialog"

This reverts commit d0832dc5e7f0657744780cdfc97ed40772ea717c.

msgid

warnings.push_back(RTR("A SpriteFrames resource must be created or set in the \"Sprite Frames\"

revert editor/translations/editor
@MovaUA
Copy link
Contributor Author

MovaUA commented Jul 9, 2024

You'll need to squash the commits into 1.

✅ git rebase to a single commit is done.

@KoBeWi KoBeWi added this to the 4.3 milestone Jul 9, 2024
@MovaUA MovaUA mentioned this pull request Jul 9, 2024
Closed
@akien-mga akien-mga merged commit fbac9c5 into godotengine:master Jul 10, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@MovaUA
Copy link
Contributor Author

MovaUA commented Jul 11, 2024 •
edited
Loading

Thanks! And congrats for your first merged Godot contribution 🎉

Great! 😊
That was a pleasure 😊
GODOT is awesome! 👏

@MovaUA MovaUA deleted the fixes/node-configuration-warning-dialog-text branch July 11, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:2d topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Incorrect text in the Node Configuration Warning dialog
3 participants
@MovaUA @KoBeWi @akien-mga