Fix edited node being removed before editor plugin handles focus loss #94162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Most excellent! |
`CanvasItemEditor::_select_click_on_item` was causing `EditorNode::_plugin_over_edit` to be called before focus exit had time to propagate to `SpriteFramesEditor::_animation_speed_changed`.
anniryynanen
force-pushed
the
sprite-frames-crash
branch
from
109c713
to
4a27fb7
Compare
KoBeWi
approved these changes
Jul 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanvasItemEditor::_select_click_on_itemwas causingEditorNode::_plugin_over_editto be called before focus exit had time to propagate toSpriteFramesEditor::_animation_speed_changed.Fixes #93817.
The defer is needed, but I'm not sure if this is the best place to put it.