Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make errors on RefCounted.free() more accurate #94238

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

RandomShaper
Copy link
Member

When attempting to call free() on a RefCounted object, GDScript complains that you have tried to free "a reference."

Reference was renamed to RefCounted in Godot 4. Therefore, the wording warrants an update, for consistency and clarity.

@RandomShaper RandomShaper added enhancement topic:gdscript cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 11, 2024
@RandomShaper RandomShaper requested a review from a team as a code owner July 11, 2024 22:06
@Mickeon Mickeon added this to the 4.3 milestone Jul 12, 2024
@dalexeev
Copy link
Member

Please update it here too:

ERR_FAIL_V_MSG(Variant(), "Can't 'free' a reference.");

@RandomShaper RandomShaper requested a review from a team as a code owner July 12, 2024 14:37
@RandomShaper RandomShaper changed the title GDScript: Make error on RefCounted.free() more accurate Make errors on RefCounted.free() more accurate Jul 12, 2024
core/object/object.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga changed the title Make errors on RefCounted.free() more accurate Make errors on RefCounted.free() more accurate Jul 17, 2024
@akien-mga akien-mga merged commit ab67408 into godotengine:master Jul 17, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the ref_is_now_rc branch July 17, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release enhancement topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants