Fix resources being skipped in InstancePlaceholder #94345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:core
regression
topic:editor
and removed
topic:core
labels
matheusmdx
force-pushed
the
fix-instance-placeholder-with-resource
branch
from
5c7e81a
to
75c4df0
Compare
akien-mga
reviewed
Jul 17, 2024
matheusmdx
force-pushed
the
fix-instance-placeholder-with-resource
branch
from
75c4df0
to
2f0beee
Compare
akien-mga
reviewed
Jul 17, 2024
matheusmdx
force-pushed
the
fix-instance-placeholder-with-resource
branch
from
2f0beee
to
260c051
Compare
akien-mga
approved these changes
Jul 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #94266
I also tested with mrp from #88662 (comment) and seems to be working as expected