Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CI: Pin Python 3.12.3 to workaround GHA issue" #94442

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jul 16, 2024

The pinned version is no longer needed, as the issue in question was fixed via actions/python-versions#286. In the future, this kind of change shouldn't be necessary, as runners requiring different builds can simply supply a pinned python version instead. If the issue was still present, the preferred implementation would be:

# macos_builds.yml
...
      - name: Setup Python and SCons
        uses: ./.github/actions/godot-deps
        with:
          # Workaround GHA unable to extract 3.12.4 tarball
          python-version: 3.12.3
...

@Repiteo Repiteo added enhancement topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 16, 2024
@Repiteo Repiteo added this to the 4.3 milestone Jul 16, 2024
@Repiteo Repiteo requested a review from akien-mga July 16, 2024 16:54
@Repiteo Repiteo requested a review from a team as a code owner July 16, 2024 16:54
@akien-mga akien-mga removed cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 22, 2024
@akien-mga akien-mga merged commit eb6c914 into godotengine:master Jul 22, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Repiteo Repiteo deleted the ci/revert-python-version branch July 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants