Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic-stack-buffer-overflow crash when executing random functions on random physics objects #94521

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix dynamic-stack-buffer-overflow crash when executing random functions on random physics objects #94521

merged 1 commit into from
Jul 19, 2024

Conversation

jamie-pate
Copy link
Contributor

…ns on random physics objects

Fixes #92333

This looks correct, and fixes the ASAN assertion I'm currently getting in my program.

@jamie-pate
Fix dynamic-stack-buffer-overflow crash when executing random functio…
eb5f129 
…ns on random physics objects

Fixes godotengine#92333

This looks correct, and fixes the ASAN assertion I'm currently getting
in my program.
@jamie-pate jamie-pate requested a review from a team as a code owner July 19, 2024 02:22
@clayjohn clayjohn added this to the 4.3 milestone Jul 19, 2024
clayjohn
clayjohn approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't know anything about physics, but I feel comfortable approving this one...

@akien-mga akien-mga changed the title Fix dynamic-stack-buffer-overflow crash when executing random functio… Fix dynamic-stack-buffer-overflow crash when executing random functions on random physics objects Jul 19, 2024
akien-mga
akien-mga approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this was clearly a typo. The 2D physics code is already correct and exactly the same as what this PR changes 3D to.

Now I wonder what other open issues this might fix.

@akien-mga akien-mga added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 19, 2024
@akien-mga akien-mga merged commit d9bfdfd into godotengine:master Jul 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@jamie-pate
Copy link
Contributor Author

Traced to this commit 3 years ago.. how did this work even work for so long :D like, i'm amazed this didn't cause more crashes, I guess that's the problem with memory corruption, it is incredibly random if you don't have the exact circumstances that trigger it...

38f2e32#diff-7837128e281a94fe78ebe9eeb43bd7a9d0b1d1c2073b2bbd9c2660d688ee860eL428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release crash topic:physics
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

dynamic-stack-buffer-overflow crash when executing random functions on random physics objects
3 participants
@jamie-pate @akien-mga @clayjohn