OpenXR: Fix enabling passthrough via environment blend mode in project settings #94550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Jul 19, 2024
dsnopek
force-pushed
the
openxr-passthrough-project-settings
branch
from
a4af6ac
to
22a6303
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #87630 made it possible to enable passthrough by setting the environment blend mode to "alpha blend", even on headsets that need to use a special passthrough extension - in that case it works by emulating alpha blend mode.
Currently, this is working great if you set the environment blend mode via code!
However, it you set it in project settings, you'll get this error:
This is because we're checking the blend mode before OpenXR extension wrappers have had the opportunity to enable emulation of alpha blend mode.
This PR basically moves these checks to later, after
on_session_created()is run on all the extension wrappers.