Documentation: Update link in CONTRIBUTING.md #94565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there is more than one spot where the invalid link is used, updating those other spots now. |
This comment was marked as resolved.
This comment was marked as resolved.
Hey there, first time contributing and I'm in the middle of reading the contribution best practice, so sorry for any mistakes in this pull request. When clicking the **Contributing section** link under the **Contributors guidelines** title, this linked to the Godot *page not found* link. I changed the link from `https://docs.godotengine.org/en/latest/contributing/ways_to_contribute.html` to `https://docs.godotengine.org/en/latest/contributing/how_to_contribute.html`. Now, when a user clicks the link, it will redirect them to the start of the contribution documentation.
Gearhartlove
force-pushed
the
update-contribution-link
branch
from
872352d
to
ebb80c6
Compare
|
Ok should be rebased now 👍 |
That means the redirect isn't working correctly, even though it was added in godotengine/godot-docs#9609. |
|
Thank you @AThousandShips for updating the CSV redirects, I didn't know that existed 😅 . One question I have is, do we want the "old link" to be in the CONTRIBUTING.md doc still, or does it not matter because we redirect? |
|
Should be updated here I'd say to help along |
akien-mga
changed the title
akien-mga
changed the title
akien-mga
approved these changes
Jul 22, 2024
akien-mga
added
documentation
cherrypick:3.x
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, first time contributing and I'm in the middle of reading the contribution best practice, so sorry for any mistakes in this pull request.
When clicking the Contributing section link under the Contributors guidelines title, this linked to the Godot page not found link.
I changed the link from
https://docs.godotengine.org/en/latest/contributing/ways_to_contribute.htmltohttps://docs.godotengine.org/en/latest/contributing/how_to_contribute.html.Now, when a user clicks the link, it will redirect them to the start of the contribution documentation.