Fix incorrect Curve editor preview thumbnail scaling #94571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`EDSCALE` scaling was applied even though it shouldn't be, which led to pixelated thumbnails due to double scaling. For reference, AudioStream previews don't use `EDSCALE` and look fine at any editor scale (the editor itself already scales the thumbnail requests).
akien-mga
approved these changes
Jul 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDSCALEscaling was applied even though it shouldn't be, which led to pixelated thumbnails due to double scaling. For reference, AudioStream previews don't useEDSCALEand look fine at any editor scale (the editor itself already scales the thumbnail requests).cc @Geometror - I noticed other preview generators such as the Gradient one also use
EDSCALE. It should probably be removed there as well but I haven't done extensive testing yet.Preview
Disregard the different background colors (I was using a slightly older commit than #94494 for the Before screenshots).
75% editor scale
175% editor scale